Skip to content

TST: split chaining tests #39684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 1 commit into from
Feb 8, 2021
Merged

TST: split chaining tests #39684

jreback merged 1 commit into from
Feb 8, 2021

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Feb 8, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

jreback
jreback approved these changes Feb 8, 2021
View reviewed changes
pandas/tests/indexing/test_chaining_and_caching.py
assert df._is_copy is None
df["a"] += 1

@pytest.mark.arm_slow
Copy link
Contributor

@jreback jreback Feb 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worthile to move the slow to a separate file and just mark it

Copy link
Member Author

@jbrockmendel jbrockmendel Feb 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not wild about that pattern, but dont have a better alternative ATM. im happy enough with how it is here

Copy link
Contributor

@jreback jreback Feb 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i c. maybe leave these decorators, but split anyhow just to make it more obvious?

Copy link
Member Author

@jbrockmendel jbrockmendel Feb 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the follow-up is to see if there's only a subset of these that are actually slow

@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite labels Feb 8, 2021
@jreback jreback added this to the 1.3 milestone Feb 8, 2021
@jreback
Copy link
Contributor

jreback commented Feb 8, 2021

lgtm. small comment, ok for followon or here.

@jreback jreback merged commit df5591e into pandas-dev:master Feb 8, 2021
@jbrockmendel jbrockmendel deleted the tst-chained branch February 8, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @jreback