BUG: RollingGroupby no longer keeps the groupby column in the result #40341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @pandas-dev/pandas-core, @pandas-dev/pandas-triage if any comments (this was a discussion item on the call i think month before last) |
Member
Author
| if _grouper is None: | ||
| raise ValueError("Must pass a Grouper object.") | ||
| self._grouper = _grouper | ||
| # GH 32262: It's convention to keep the grouping column in |
Member
There was a problem hiding this comment.
is the difference in conventions just a historical thing? might we want to make these match eventually?
Member
Author
There was a problem hiding this comment.
Seems to be historical #32332 (review)
Would be great to have groupby apply match but might take come convincing
Contributor
|
thanks @mroeschke |
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowed some work from #32332