Skip to content

Conversation

@simonjayhawkins
Copy link
Member

xref #41807 (comment)

this does not update the __array__ to to_numpy methods of EA, see #41185 (comment) but does need a couple of ignores till that is done.

(we are removing 3 anyway, so a net reduction in ignores 😄, and reducing false positives for users)

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Jun 11, 2021
@jreback
Copy link
Contributor

jreback commented Jun 25, 2021

does this require 1.21? (though passing for all so guess is no)

@jreback jreback added this to the 1.4 milestone Jun 25, 2021
@simonjayhawkins
Copy link
Member Author

for runtime, npt: Any = None means that the numpy version is not relevant. For type checking, import numpy.typing as npt so needs at least 1.20, but would not be checking without 1.21 anyway otherwise will get other errors.

@jreback jreback merged commit 50a59ba into pandas-dev:master Jun 25, 2021
@jreback
Copy link
Contributor

jreback commented Jun 25, 2021

thanks @simonjayhawkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants