Skip to content

Revert "REF: move shift logic from BlockManager to DataFrame" #42317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonjayhawkins merged 1 commit into from
Jun 30, 2021
Merged

Revert "REF: move shift logic from BlockManager to DataFrame" #42317

simonjayhawkins merged 1 commit into from
Jun 30, 2021

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jun 30, 2021

Reverts #40536

Discussed in #42246, we can revert for 1.3 without breaking anything, then un-revert in 1.4 and have some time to sort out the perf trouble.

@simonjayhawkins simonjayhawkins added the Performance Memory or execution speed performance label Jun 30, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Jun 30, 2021
@simonjayhawkins
Copy link
Member

simonjayhawkins commented Jun 30, 2021 

(pandas-dev) simon@T3630:~/pandas/asv_bench (revert-40536-ref-shift)$ asv compare v1.3.0.dev0 e496d4aa22df656adfab14ec216e66198732e1c5 |grep frame_methods.Shift.time_shift
       6.05±0.1ms      5.51±0.03ms     0.91  frame_methods.Shift.time_shift(0)
-        540±30μs         478±10μs     0.88  frame_methods.Shift.time_shift(1)

@simonjayhawkins simonjayhawkins merged commit 027d374 into master Jun 30, 2021
@simonjayhawkins simonjayhawkins deleted the revert-40536-ref-shift branch June 30, 2021 07:26
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 30, 2021
@jbrockmendel @meeseeksmachine
Backport PR pandas-dev#42317: Revert "REF: move shift logic from Bloc…
0380ea0 
…kManager to DataFrame"
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 30, 2021
Merged
@simonjayhawkins
Copy link
Member

simonjayhawkins commented Jun 30, 2021

Thanks @jbrockmendel

simonjayhawkins added a commit that referenced this pull request Jun 30, 2021
@simonjayhawkins
Revert "Revert "REF: move shift logic from BlockManager to DataFrame (#…
a62d90f 
…40536)" (#42317)"

This reverts commit 027d374.
@simonjayhawkins simonjayhawkins mentioned this pull request Jun 30, 2021
Closed
simonjayhawkins pushed a commit that referenced this pull request Jun 30, 2021
@meeseeksmachine @jbrockmendel
Backport PR #42317: Revert "REF: move shift logic from BlockManager t…
f1d1367 
…o DataFrame" (#42321)

Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
Revert "REF: move shift logic from BlockManager to DataFrame (pandas-…
8f6840f 
…dev#40536)" (pandas-dev#42317)

This reverts commit 9535280.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Performance Memory or execution speed performance

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @simonjayhawkins