Skip to content

Conversation

@jbrockmendel
Copy link
Member

2 logic-neutral prelims split off from other branches

  1. instead of catching and re-issuing TypeError in NDFrame.xs, just issue it with the correct exception message in the first place
  2. inside _get_loc_level there is a 'k' variable that is serving a dual purpose as a loop index and as a variable inside that loop. AFAICT this is for a small code-de-duplication in checking for slices, but it turns out we need to treat slices differently in the two cases. This changes the inside variable to loc_level

@jreback jreback added this to the 1.4 milestone Jul 7, 2021
@jreback jreback added the Refactor Internal refactoring of code label Jul 7, 2021
@jreback jreback merged commit a9b6e5f into pandas-dev:master Jul 7, 2021
@jbrockmendel jbrockmendel deleted the ref-get_loc_level-catch branch July 7, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MultiIndex Refactor Internal refactoring of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants