Skip to content

TYP: Fix typing for searchsorted #42788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dr-Irv merged 2 commits into from
Jul 29, 2021
Merged

TYP: Fix typing for searchsorted #42788

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2e7127
TYP: Fix typing for searchsorted
rhshadrach Jul 29, 2021
48fbe77
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
rhshadrach Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pandas/core/reshape/tile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from typing import (
Any,
Callable,
Literal,
)

import numpy as np
Expand Down Expand Up @@ -417,12 +418,8 @@ def _bins_to_cuts(
else:
bins = unique_bins

side = "left" if right else "right"
# error: No overload variant of "searchsorted" of "ndarray" matches
# argument types "Any", "str"
ids = ensure_platform_int(
bins.searchsorted(x, side=side) # type: ignore[call-overload]
)
side: Literal["left", "right"] = "left" if right else "right"
ids = ensure_platform_int(bins.searchsorted(x, side=side))

if include_lowest:
ids[np.asarray(x) == bins[0]] = 1
Expand Down