REGR: sample modifying weights inplace
#42843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
added
Algos
KrishnaSai2020
approved these changes
Aug 3, 2021
Contributor
KrishnaSai2020
left a comment
KrishnaSai2020
left a comment
There was a problem hiding this comment.
Appears to be fine.
Contributor
|
looks fine can you add a whatsnew note (1.4) reshaping is fine & ping on green. |
Member
Author
Didn't include a whatsnew because it is only a regression on master caused by #42233 |
Contributor
kk cool |
Contributor
|
thanks @mzeitlin11 |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting 1.4 and no whatsnew since only a regression on master.