Skip to content

TST: df.combine_first duplicates rows for nan index values (#39881) #43066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 4 commits into from
Aug 17, 2021
Merged

TST: df.combine_first duplicates rows for nan index values (#39881) #43066

jreback merged 4 commits into from
Aug 17, 2021

Conversation

@ssche
Copy link
Contributor

@ssche ssche commented Aug 16, 2021

@simonjayhawkins simonjayhawkins changed the title Added test case (#39881) TST: df.combine_first duplicates rows for nan index values (#39881) Aug 16, 2021
@simonjayhawkins simonjayhawkins added Testing pandas testing functions or related to the test suite Indexing Related to indexing on series/frames, not to indexes themselves Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate MultiIndex labels Aug 16, 2021
ssche added 2 commits August 16, 2021 23:28
@ssche
Fixed build error
7d0485b 
* "found both 'pd.DataFrame' and 'DataFrame' in the same file"
@ssche
Fixed formatting
b2478bf
phofl
phofl reviewed Aug 16, 2021
View reviewed changes
@jreback jreback added this to the 1.4 milestone Aug 16, 2021
@ssche
Addressed review comments
8a55f85 
* Explicitly define index in constructor
@ssche ssche requested a review from phofl August 16, 2021 23:57
phofl
phofl approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jreback jreback merged commit 9376815 into pandas-dev:master Aug 17, 2021
@jreback
Copy link
Contributor

jreback commented Aug 17, 2021

thanks @ssche

@ssche ssche deleted the gh39881-combine_first-duplicates-rows-for-nan-index-values branch August 18, 2021 03:16
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@ssche @feefladder
TST: df.combine_first duplicates rows for nan index values (pandas-de…
afd6c31 
…v#39881) (pandas-dev#43066)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phofl phofl phofl approved these changes

Assignees

No one assigned

Labels

Indexing Related to indexing on series/frames, not to indexes themselves Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate MultiIndex Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

1.4

Development

Successfully merging this pull request may close these issues.

BUG: df.combine_first duplicates rows for nan index values

4 participants

@ssche @jreback @phofl @simonjayhawkins