TST: added test for to_string when max_rows is zero (GH35394) #43300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimcmaster1
added
Testing
| def test_to_string_max_rows_zero(data, expected): | ||
| # GH35394 | ||
| result = DataFrame(data=data).to_string(max_rows=0) | ||
|
|
Member
There was a problem hiding this comment.
Can remove this blank line
alimcmaster1
requested changes
Aug 31, 2021
Member
alimcmaster1
left a comment
alimcmaster1
left a comment
There was a problem hiding this comment.
Thanks for the PR. Minor comments
| " col1 col2\n0 1 3\n1 2 4", | ||
| ), | ||
| ( | ||
| {"col1": [0, 2, 4], "col2": [3, 4, 5]}, |
Member
There was a problem hiding this comment.
This test case seems pretty similar to the first is it really needed?
Contributor
Author
|
Thanks for the review @alimcmaster1 |
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
thanks @lorenzophys |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
df.to_string(max_rows=0)#35394Provided tests for
to_stringwhenmax_rows=0.Tests and linter pass locally.