Backport PR #43152 on branch 1.3.x (BUG: Outer/right merge with EA dtypes cast to object) #43389
Conversation
lumberbot-app
bot
added
Bug
ExtensionArray
|
Is this because, maybe |
| ([1], "left"), | ||
| ], | ||
| ) | ||
| def test_merge_EA_dtype(self, any_numeric_ea_dtype, how, expected_data): |
There was a problem hiding this comment.
yep need to change this for 1.3.x
There was a problem hiding this comment.
So, I should make the change in this PR then, right?
There was a problem hiding this comment.
yes in this PR itself (as it targets the backport branch)
There was a problem hiding this comment.
since I did not create this PR, not able to edit it
There was a problem hiding this comment.
adding this parametrisation definition should resolve this
@pytest.mark.parametrize(
"any_numeric_ea_dtype",
[
"UInt8",
"Int8",
"UInt16",
"Int16",
"UInt32",
"Int32",
"UInt64",
"Int64",
"Float32",
"Float64",
],
)
There was a problem hiding this comment.
Isn't this any_nullable_numeric_dtype on 1.3.x?
There was a problem hiding this comment.
Ah! right, I see it here
But again would need help from maintainer to amend this PR.
|
Hello @meeseeksmachine! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-09-04 18:47:28 UTC |
|
Rats. The line got too long when I updated the name in the web editor. I'll fix it if all other CI passes. |
|
@github-actions pre-commit |
lithomas1
left a comment
lithomas1
left a comment
There was a problem hiding this comment.
Tests seem to pass. LGTM after the pre-commit bot does its thing.
|
thanks @debnathshoham and @lithomas1 |
5 participants
Backport PR #43152: BUG: Outer/right merge with EA dtypes cast to object