Skip to content

BUG: rename fails when using level #43667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 12 commits into from
Sep 27, 2021
Merged

BUG: rename fails when using level #43667

jreback merged 12 commits into from
Sep 27, 2021

Conversation

@wojtek2kdev
Copy link
Contributor

@wojtek2kdev wojtek2kdev commented Sep 20, 2021 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Sep 20, 2021 •
edited
Loading

Hello @wojtek2kdev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-09-23 15:45:42 UTC

@jreback jreback changed the title 43659-bugfix BUG: rename fails when using level Sep 20, 2021
phofl
phofl reviewed Sep 20, 2021
View reviewed changes
pandas/tests/generic/test_series.py Outdated

# issue #43659
def test_rename_with_multiindex(self):
arrays = [
Copy link
Member

@phofl phofl Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add reference in test not above

The test is to complicated. Please reduce number of rows and don't use something like list(zip(*arrays)). You can use MultiIndex.from_arrays

@phofl
Copy link
Member

phofl commented Sep 20, 2021

Also need whatsnew

@wojtek2kdev
Copy link
Contributor Author

wojtek2kdev commented Sep 20, 2021

@phofl Sorry, it's my first PR to this project. What is "whatsnew entry"?

@phofl
Copy link
Member

phofl commented Sep 20, 2021

Check doc/source/whatsnew. These are our release notes. Yours should go into 1.4

@wojtek2kdev
Copy link
Contributor Author

wojtek2kdev commented Sep 20, 2021

@phofl I'm not sure, but all of failed checks are my fault? For example: https://github.com/pandas-dev/pandas/pull/43667/checks?check_run_id=3655863372. I checked this test locally and it passes.

jreback
jreback requested changes Sep 21, 2021
View reviewed changes
pandas/tests/generic/test_series.py Outdated
Series._metadata = _metadata
Series.__finalize__ = _finalize # FIXME: use monkeypatch

def test_rename_with_multiindex(self):
Copy link
Contributor

@jreback jreback Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move here: pandas/tests/series/methods/test_rename.py

@wojtek2kdev wojtek2kdev requested a review from jreback September 22, 2021 20:26
jreback
jreback requested changes Sep 23, 2021
View reviewed changes
@jreback jreback added this to the 1.4 milestone Sep 23, 2021
@jreback jreback added the Bug label Sep 23, 2021
@wojtek2kdev wojtek2kdev requested a review from jreback September 23, 2021 16:00
@jreback jreback merged commit 21c2991 into pandas-dev:master Sep 27, 2021
@jreback
Copy link
Contributor

jreback commented Sep 27, 2021

thanks @wojtek2kdev very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback approved these changes

@phofl phofl Awaiting requested review from phofl

Assignees

No one assigned

Labels

Bug MultiIndex

Projects

None yet

Milestone

1.4

Development

Successfully merging this pull request may close these issues.

BUG: rename fails when using level

4 participants

@wojtek2kdev @pep8speaks @phofl @jreback