Skip to content

Conversation

@cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 27, 2013

This PR fixes an issue where joining a PeriodIndex with itself resulted in a
new object.

@ghost ghost assigned cpcloud Jul 27, 2013
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the key change

@cpcloud
Copy link
Member Author

cpcloud commented Jul 27, 2013

also i did a vbench run and everything was kosher

@cpcloud
Copy link
Member Author

cpcloud commented Jul 28, 2013

@jreback mergeable?

@jreback
Copy link
Contributor

jreback commented Jul 28, 2013

looks ok....prob let's wait till after py3 stuff in though....

@cpcloud
Copy link
Member Author

cpcloud commented Jul 29, 2013

sounds good

cpcloud added a commit that referenced this pull request Jul 30, 2013
BUG: fix period index object instantiation when joining with self
@cpcloud cpcloud merged commit 6ae36e4 into pandas-dev:master Jul 30, 2013
@cpcloud cpcloud deleted the self-join-index-is-same branch July 30, 2013 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants