TST: Test Series' settitem with Interval and NaN #43844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Categorical
jreback
requested changes
Oct 1, 2021
pandas/tests/indexing/test_iloc.py
Outdated
| expected = Series([NaT, 1, 2], dtype="timedelta64[ns]") | ||
| tm.assert_series_equal(series, expected) | ||
|
|
||
| def test_setitem_mix_of_nan_and_interval(self): |
Contributor
There was a problem hiding this comment.
can you parameterize on all the cases in the OP
Contributor
Author
There was a problem hiding this comment.
Thanks, I parametrized the NA and the non-NA value, let me know if I should add more cases.
Fixes pandas-dev#27937. As described in that issue, assigning a mixture of NaN and Interval values into a slice of a categorical-typed series would raise an exception. This is no longer the case.
ElDeveloper
force-pushed
the
fixes-27937
branch
from
97ee2aa to
e0a29ca
Compare
ElDeveloper
commented
Oct 4, 2021
jreback
requested changes
Oct 4, 2021
pandas/tests/indexing/test_iloc.py
Outdated
| tm.assert_series_equal(series, expected) | ||
|
|
||
| @pytest.mark.parametrize("not_na", [Interval(0, 1), "a", 1.0]) | ||
| @pytest.mark.parametrize("na", [np.nan, NaT]) |
Contributor
Author
There was a problem hiding this comment.
Very cool, yes. Fixed.
jreback
approved these changes
Oct 5, 2021
Contributor
|
thanks @ElDeveloper very nice! |
Contributor
Author
|
Thanks so much for your feedback! |
gasparitiago
pushed a commit
to gasparitiago/pandas
that referenced
this pull request
Oct 9, 2021
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27937. As described in that issue, assigning a mixture of NaN and
Interval values into a slice of a categorical-typed series would raise
an exception. This is no longer the case.