Skip to content

Conversation

@jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment

def test_get_loc_time_obj2(self):
# GH#8667

from pandas._libs.index import _SIZE_CUTOFF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reason you are importing here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bc that's how it is in master (best guess is that is due to a code check for private imports but i havent checked that)

@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 7, 2021
@jreback jreback added this to the 1.4 milestone Oct 7, 2021
@jreback jreback merged commit f4e7fdc into pandas-dev:master Oct 8, 2021
gasparitiago pushed a commit to gasparitiago/pandas that referenced this pull request Oct 9, 2021
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants