TYP: type annotations for nancorr #44227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
commented
Oct 29, 2021
| cov: bool = ..., | ||
| minp=..., | ||
| ) -> np.ndarray: ... # ndarray[float64_t, ndim=2] | ||
| minp: int | None = ..., |
Member
Author
There was a problem hiding this comment.
we may pass None from pandas/core/frame.py:9667. base_cov = libalgos.nancorr(mat, cov=True, minp=min_periods)
In nancorr_spearman we don't allow None, if not specified, the default is 1, specified in the function signature.
The default is also 1 in nancorr, coded if None which is the signature default.
Not sure whether this inconsistency is a big deal.
Contributor
There was a problem hiding this comment.
could open an issue about this
simonjayhawkins
commented
Oct 29, 2021
| mat: npt.NDArray[np.float64], # ndarray[float64_t, ndim=2] | ||
| minp: int = ..., | ||
| ) -> np.ndarray: ... # ndarray[float64_t, ndim=2] | ||
| def nancorr_kendall( |
| mat: np.ndarray, # ndarray[float64_t, ndim=2] | ||
| minp: int = ..., | ||
| ) -> np.ndarray: ... # ndarray[float64_t, ndim=2] | ||
| ) -> npt.NDArray[np.float64]: ... # ndarray[float64_t, ndim=2] |
Member
There was a problem hiding this comment.
have you heard anything about if/when/how npt.NDArray is going to support something equivalent to ndim=2?
jreback
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.