TYP: use TYPE_CHECKING for import_optional_dependency("numba") #44273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There is one more: pandas/core/window/numba_.py:261 After that one you can also remove the pyright comment from the file. If |
twoertwein
approved these changes
Nov 2, 2021
Member
|
@simonjayhawkins I'd be happy to merge this PR (after rebasing), but I'm not sure whether I (as the only reviewer so far) am allowed/supposed to also merge it? |
Contributor
|
@twoertwein can you merge master and @mroeschke if you can have a look |
mroeschke
approved these changes
Nov 29, 2021
Contributor
|
thanks @simonjayhawkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #44233 (comment) or could go with #44254 (comment) instead.
cc @twoertwein