BUG: DataFrame.shift with axis=1 and mismatched fill_value #44564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Missing-data
jreback
requested changes
Nov 25, 2021
|
|
||
| if axis == 0 and self.ndim == 2 and self.nblocks > 1: | ||
| if ( | ||
| axis == 0 |
Contributor
There was a problem hiding this comment.
this is super complicated can you split into multiple clauses & add comments
Member
Author
There was a problem hiding this comment.
sure will comment. fortunately we can rip out some of this in 2.0
Member
Author
There was a problem hiding this comment.
comment added + green
Contributor
|
user facing? |
Member
Author
yes, there's a whatsnew (forgot to check the checkbox until just now) |
jreback
approved these changes
Nov 25, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.