BUG: Series.mode with dt64tz or PeriodDtype #44582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 25, 2021
| # type, _SupportsDType, str, Union[Tuple[Any, int], Tuple[Any, Union[int, | ||
| # Sequence[int]]], List[Any], _DTypeDict, Tuple[Any, Any]]]" | ||
| return self._ndarray.view(dtype=dtype) # type: ignore[return-value,arg-type] | ||
| return super().view(dtype) |
Contributor
There was a problem hiding this comment.
can you remove this entirely (since it will just user the super view anyhow)?
Member
Author
There was a problem hiding this comment.
not with the @overloads just above this
| assert res.dtype == ser.dtype | ||
| tm.assert_series_equal(res, ser) | ||
|
|
||
| res = pd.core.algorithms.mode(ser._values) |
Contributor
There was a problem hiding this comment.
don't we have a rule which prevents this? e.g. can you import at the top instead
Member
Author
There was a problem hiding this comment.
not sure about the rule. will move the import
4 tasks
Contributor
|
i ithink this needs a rebase as merged the underlying PR |
Member
Author
|
Rebased +greenish |
jreback
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sits on top of #44581