ENH: Add numba engine to groupby.var/std #44862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Dec 13, 2021
mroeschke
commented
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
approved these changes
Dec 13, 2021
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
thanks @mroeschke followup request
| func: Callable, | ||
| engine_kwargs: dict[str, bool] | None, | ||
| numba_cache_key_str: str, | ||
| *aggregator_args, |
Member
Author
There was a problem hiding this comment.
Numba functions don't play nice with kwargs currently numba/numba#2916
| ``compute.use_numba`` | ||
| .. versionadded:: 1.4.0 | ||
Contributor
There was a problem hiding this comment.
in a followup can you try to use shared docstrings here (and the other functions) for the engine/engine_kwargs
Member
Author
There was a problem hiding this comment.
Sure I can try to upstream these doc parameters from rolling too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.