Skip to content

BUG: read_excel loading some xlsx ints as floats #47121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 3 commits into from
Jun 6, 2022
Merged

BUG: read_excel loading some xlsx ints as floats #47121

mroeschke merged 3 commits into from
Jun 6, 2022

Conversation

@ahawryluk
Copy link
Contributor

@ahawryluk ahawryluk commented May 25, 2022

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions IO Excel read_excel, to_excel labels Jun 5, 2022
@jreback jreback added this to the 1.4.3 milestone Jun 5, 2022
@mroeschke mroeschke added the Regression Functionality that used to work in a prior pandas version label Jun 6, 2022
@mroeschke mroeschke merged commit dea624a into pandas-dev:main Jun 6, 2022
@mroeschke
Copy link
Member

mroeschke commented Jun 6, 2022

Thanks @ahawryluk

@lumberbot-app

This comment was marked as resolved.

Sign in to view
@ahawryluk ahawryluk mentioned this pull request Jun 6, 2022
Closed
3 tasks
@ahawryluk ahawryluk deleted the xlsx_ints branch June 7, 2022 03:22
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Jun 7, 2022
@ahawryluk @simonjayhawkins
Backport PR pandas-dev#47121: BUG: read_excel loading some xlsx ints …
13a0076 
…as floats
@simonjayhawkins simonjayhawkins mentioned this pull request Jun 7, 2022
Merged
simonjayhawkins added a commit that referenced this pull request Jun 7, 2022
@simonjayhawkins @ahawryluk
Backport PR #47121 on branch 1.4.x (BUG: read_excel loading some xlsx…
17386d1 
… ints as floats) (#47271)

Backport PR #47121: BUG: read_excel loading some xlsx ints as floats

Co-authored-by: Andrew Hawyrluk <50434302+ahawryluk@users.noreply.github.com>
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@ahawryluk @jreback @yehoshuadimarsky
BUG: read_excel loading some xlsx ints as floats (pandas-dev#47121)
5229259 
* Reintoduce integer conversion when reading xlsx

* whats new 1.4.3

Co-authored-by: Jeff Reback <jeff@reback.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Dtype Conversions Unexpected or buggy dtype conversions IO Excel read_excel, to_excel Regression Functionality that used to work in a prior pandas version

Projects

None yet

Milestone

1.4.3

Development

Successfully merging this pull request may close these issues.

BUG: read_excel does not convert integral floats to ints when backed by openpyxl

4 participants

@ahawryluk @mroeschke @jreback @simonjayhawkins