REF: PandasColumn.describe_categorical returns categores instead of mapping #47886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@vnlitvinov ok? |
rgommers
approved these changes
Aug 9, 2022
Contributor
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
This LGTM. One small comment on a static typing issue.
| mapping = categorical["mapping"] | ||
| assert isinstance(mapping, dict), "Categorical mapping must be a dict" | ||
| categories = np.array(tuple(mapping[k] for k in sorted(mapping))) | ||
| categories = np.array(categorical["categories"]._col) # type:ignore[union-attr] |
Contributor
There was a problem hiding this comment.
The assert above looks like it was there to help Mypy (type narrows the union to the actual type, before a dict and now an np.array). Did you try updating rather than removing it? It may remove the need for this type:ignore and the entry in the pyright_ file.
Member
Author
There was a problem hiding this comment.
Thanks for the catch! Added back an assertion to prevent ignoring typing here.
YYYasin19
pushed a commit
to YYYasin19/pandas
that referenced
this pull request
Aug 23, 2022
3 tasks
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: data-apis/dataframe-api#69
cc @shwina @vnlitvinov