Skip to content

Conversation

@phofl
Copy link
Member

@phofl phofl commented Aug 18, 2022

This gets ci green for now, but have to investigate what is wrong here. The first failing build updated conda from 4.13 to 4.14 with the conda install mamba command, hence the pin there

cc @mroeschke

@phofl phofl marked this pull request as draft August 18, 2022 21:56
@phofl phofl changed the title Try pinning conda in docker build CI: Pin conda in docker build Aug 18, 2022
@phofl phofl added the CI Continuous Integration label Aug 18, 2022
@phofl phofl marked this pull request as ready for review August 18, 2022 22:19
@mroeschke mroeschke added this to the 1.4.4 milestone Aug 18, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this eventually affect other builds?

@phofl
Copy link
Member Author

phofl commented Aug 18, 2022

Not sure. We are using micromamba for most builds, so should not. I'll open a pr in parallel to check if we can switch to mambaforge as base image here. This should solve this.

@mroeschke
Copy link
Member

Not sure. We are using micromamba for most builds, so should not. I'll open a pr in parallel to check if we can switch to mambaforge as base image here. This should solve this.

Sounds good. Switching to micromamba would probably be a preferred fix here.

@phofl
Copy link
Member Author

phofl commented Aug 18, 2022

Yep agreed. This is only a temporary solution to get the ci passing agai anyway

@phofl
Copy link
Member Author

phofl commented Aug 19, 2022

#48143 uses mambaforge as base image. Gets the ci back to green too

@simonjayhawkins
Copy link
Member

#48143 uses mambaforge as base image. Gets the ci back to green too

is that the preference? and close this one?

@mroeschke
Copy link
Member

#48143 uses mambaforge as base image. Gets the ci back to green too

is that the preference? and close this one?

Yes, that would be my preference.

@phofl
Copy link
Member Author

phofl commented Aug 19, 2022

Yep, let’s merge the other pr

@phofl phofl closed this Aug 19, 2022
@phofl phofl deleted the pin_conda branch August 20, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants