ENH: Add index param to df.to_dict #48429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
Thanks @yuanx749, nice PR. General idea looks good, I just added couple of comments.
datapythonista
approved these changes
Sep 10, 2022
Member
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
Thanks for the updates @yuanx749, really nice, lgtm
mroeschke
reviewed
Sep 12, 2022
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Looks pretty good. Could you resolve the merge conflict?
Contributor
Author
Resolved. |
mroeschke
approved these changes
Sep 13, 2022
Member
|
Thanks @yuanx749 |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* EHN: Add index param to df.to_dict * Add whatsnew * Move whatsnew * Refactor duplicate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexparam toto_dictlike into_json. #46398doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.