Skip to content

BUG: preserve EA in pd.array #48889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 2 commits into from
Oct 3, 2022
Merged

BUG: preserve EA in pd.array #48889

mroeschke merged 2 commits into from
Oct 3, 2022

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Sep 30, 2022

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel jbrockmendel mentioned this pull request Oct 1, 2022
Merged
@mroeschke mroeschke added ExtensionArray Extending pandas with custom dtypes or arrays. Constructors Series/DataFrame/Index/pd.array Constructors labels Oct 3, 2022
mroeschke
mroeschke reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs whatsnew note?

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Oct 3, 2022

Needs whatsnew note?

The only known/tested change is for not-yet-public cases

@mroeschke mroeschke added this to the 1.6 milestone Oct 3, 2022
@mroeschke mroeschke merged commit e6024c1 into pandas-dev:main Oct 3, 2022
@mroeschke
Copy link
Member

mroeschke commented Oct 3, 2022

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the bug-pdarray-td64 branch October 3, 2022 19:38
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@jbrockmendel @noatamir
BUG: preserve EA in pd.array (pandas-dev#48889)
71ea26e 
* BUG: preserve EA in pd.array

* fix 32bit builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Constructors Series/DataFrame/Index/pd.array Constructors ExtensionArray Extending pandas with custom dtypes or arrays.

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @mroeschke