STYLE: fix pylint style checks for inherit-non-class. #48897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Oct 1, 2022
MarcoGorelli
reviewed
Oct 1, 2022
MarcoGorelli
approved these changes
Oct 1, 2022
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
looks good to me pending green
Contributor
Author
|
Thanks for reviewing quickly 😊 |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Oct 3, 2022
* fix pylint for non-class-inherit and add pre-commit changes * move ExtensionArraySupportsAnyAll to below ExtensionArray * move if TYPE_CHECKING back up to line 94 * remove erroneous space
Contributor
Author
|
Hi, @MarcoGorelli this might sound like a silly request, but is it possible to add the |
mroeschke
pushed a commit
that referenced
this pull request
Oct 11, 2022
) * BUG: Timedelta.__new__ * remove assertion * GH refs * API: Timedelta(td64_obj) retain resolution * API: Timedelta constructor pytimedelta, Tick preserve reso * STYLE: fix pylint style checks for inherit-non-class. (#48897) * fix pylint for non-class-inherit and add pre-commit changes * move ExtensionArraySupportsAnyAll to below ExtensionArray * move if TYPE_CHECKING back up to line 94 * remove erroneous space * BUG: preserve DTA/TDA+timedeltalike scalar with mismatched resos * merge main * remove debugging variable Co-authored-by: Kostya Farber <73378227+kostyafarber@users.noreply.github.com>
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* fix pylint for non-class-inherit and add pre-commit changes * move ExtensionArraySupportsAnyAll to below ExtensionArray * move if TYPE_CHECKING back up to line 94 * remove erroneous space
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…das-dev#48923) * BUG: Timedelta.__new__ * remove assertion * GH refs * API: Timedelta(td64_obj) retain resolution * API: Timedelta constructor pytimedelta, Tick preserve reso * STYLE: fix pylint style checks for inherit-non-class. (pandas-dev#48897) * fix pylint for non-class-inherit and add pre-commit changes * move ExtensionArraySupportsAnyAll to below ExtensionArray * move if TYPE_CHECKING back up to line 94 * remove erroneous space * BUG: preserve DTA/TDA+timedeltalike scalar with mismatched resos * merge main * remove debugging variable Co-authored-by: Kostya Farber <73378227+kostyafarber@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an ignore statement in the
base.py. Looks like we need to inherit a non-class in this instance.