Skip to content

CI maybe fix arm test #49476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroeschke merged 2 commits into from
Nov 2, 2022
Merged

CI maybe fix arm test #49476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcc182b
maybe fix arm test
Nov 2, 2022
95aeb52
add comment linking to issue
Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pandas/core/arrays/datetimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2231,8 +2231,10 @@ def maybe_convert_dtype(data, copy: bool, tz: tzinfo | None = None):

if is_float_dtype(data.dtype):
# pre-2.0 we treated these as wall-times, inconsistent with ints
# GH#23675, GH#45573 deprecated to treat symmetrically with integer dtypes
data = data.astype(np.int64)
# GH#23675, GH#45573 deprecated to treat symmetrically with integer dtypes.
# Note: data.astype(np.int64) fails ARM tests, see
# https://github.com/pandas-dev/pandas/issues/49468.
data = data.astype("M8[ns]").view("i8")
Copy link
Member

@jbrockmendel jbrockmendel Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this works, can you add a comment about why its needed

Copy link
Member Author

@MarcoGorelli MarcoGorelli Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to have worked in https://app.circleci.com/pipelines/github/pandas-dev/pandas/18643/workflows/978d3b67-4eb0-4d53-b42d-081554172b25/jobs/49433

sure, have added a comment

copy = False

elif is_timedelta64_dtype(data.dtype) or is_bool_dtype(data.dtype):
Expand Down