TYP:Replace union of subclasses with base class. #49587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Nov 9, 2022
mroeschke
added
IO SQL
Contributor
Author
|
@mroeschke , is it ok to merge the PR's that I create out of #48576 one at a time, or do you want me to get all the PR's set up and ready to merge first? |
mroeschke
approved these changes
Nov 14, 2022
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
LGTM (and okay to merge before the other PRs are ready) @twoertwein if you have any other comments
twoertwein
approved these changes
Nov 14, 2022
Member
|
Thank you @cdcadman ! |
5 tasks
MarcoGorelli
pushed a commit
to MarcoGorelli/pandas
that referenced
this pull request
Nov 18, 2022
Co-authored-by: Chuck Cadman <charles.cadman@standard.com>
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
Co-authored-by: Chuck Cadman <charles.cadman@standard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I am splitting this out of #49531 . In order to refactor the code in that PR, I had to change the return type of
pandasSQL_builder, and that forced me to make additional changes in order to make mypy pass in CI:pandas_sql.meta.reflect(bind=pandas_sql.connectable, only=[sql])) was failing mypy, but it can be deleted since the table is reflected inSQLDatabase.get_table, when thesqlalchemy.Tableobject is created.PandasSQLand made the abstract. I then made all the arguments agree betweenPandasSQLand subclasses.