REF: simplify maybe_convert_objects #49588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 8, 2022
| def is_float_or_complex(self): | ||
| return not (self.bool_ or self.datetime_ or self.timedelta_ | ||
| or self.nat_) | ||
| # i.e. not (anything but bool) |
Member
There was a problem hiding this comment.
Would be nice if this was def anything_but_bool as it's odd that self.bool_ = False would still return True. Maybe a followup
mroeschke
approved these changes
Nov 8, 2022
Member
|
Thanks @jbrockmendel |
Member
|
I think this may have caused a slowdown here: https://asv-runner.github.io/asv-collection/pandas/#reshape.Explode.time_explode |
Member
Author
|
what do you think the culprit is? |
Member
|
actually, looks to be #49566 - and there is some discussion there about adding a fix for the perf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also avoids some memory allocations which is nice.