Skip to content

TST/CI: Follow up fix test_write_fspath_all #49621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbrockmendel merged 1 commit into from
Nov 10, 2022
Merged

TST/CI: Follow up fix test_write_fspath_all #49621

jbrockmendel merged 1 commit into from
Nov 10, 2022

Conversation

@mroeschke
Copy link
Member

@mroeschke mroeschke commented Nov 10, 2022

Follow up to #49509, was not hitting the more stable pd.read_excel path

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail labels Nov 10, 2022
rhshadrach
rhshadrach approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ping on green.

@mroeschke mroeschke added this to the 2.0 milestone Nov 10, 2022
@mroeschke
Copy link
Member Author

mroeschke commented Nov 10, 2022

Green (except doc build which is still running and should not be impacted)

@jbrockmendel jbrockmendel merged commit 77b87fb into pandas-dev:main Nov 10, 2022
@jbrockmendel
Copy link
Member

jbrockmendel commented Nov 10, 2022

thanks @mroeschke

@mroeschke mroeschke deleted the fix/flaky_test branch November 10, 2022 20:31
codamuse pushed a commit to codamuse/pandas that referenced this pull request Nov 12, 2022
@mroeschke @codamuse
TST/CI: Follow up fix test_write_fspath_all (pandas-dev#49621)
d05207a
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
@mroeschke @mliu08
TST/CI: Follow up fix test_write_fspath_all (pandas-dev#49621)
2097d20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees

No one assigned

Labels

Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mroeschke @jbrockmendel @rhshadrach