Skip to content

ASV: Fix asv after versioneer change #49948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 1 commit into from
Nov 29, 2022
Merged

ASV: Fix asv after versioneer change #49948

mroeschke merged 1 commit into from
Nov 29, 2022

Conversation

@phofl
Copy link
Member

@phofl phofl commented Nov 28, 2022

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

#49924 broke the local ci workflow. We have to install versioner before building. Adding it to the other dependencies did not work

@phofl phofl added the Benchmark Performance (ASV) benchmarks label Nov 28, 2022
@mroeschke mroeschke added this to the 2.0 milestone Nov 29, 2022
@mroeschke mroeschke merged commit 82d271f into pandas-dev:main Nov 29, 2022
@mroeschke
Copy link
Member

mroeschke commented Nov 29, 2022

Thanks @phofl

@phofl phofl deleted the asv_fix branch January 21, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Benchmark Performance (ASV) benchmarks

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@phofl @mroeschke