BUG: loc for ea index raising with oob slice end #50170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Indexing
mroeschke
reviewed
Dec 17, 2022
| tm.assert_series_equal(ser, expected) | ||
|
|
||
|
|
||
| def test_loc_ea_numeric_index_oob_slice_end(): |
Member
There was a problem hiding this comment.
Could you also add a test for a pyarrow-backed numeric type?
Member
Author
There was a problem hiding this comment.
This would fail, int64[pyarrow] returns false in is_numeric_dtype. Is this expected? Index.is_numeric will be deprecated, so should not use that either
Member
There was a problem hiding this comment.
Ah. I think all the dtype checkers should become pyarrow aware eventually but okay not to tackle that in this PR
mroeschke
approved these changes
Dec 17, 2022
Member
|
Thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seriesslicing can fail for extension arrayIndex#50161 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.