CI: add minimal requirements file #50339
Conversation
MarcoGorelli
changed the title
|
Love the idea - needed something similar for #50046 Wondering if we shouldn't make this actually a minimal requirements file though, which would exclude pytest-cov and pytest-xdist (I think only CI needs those). Might be nice to have a true minimal file and compose the CI required-elements on top of that |
MarcoGorelli
force-pushed
the
minimal-reqs
branch
from
aa69a7b to
ba9e0dd
Compare
MarcoGorelli
force-pushed
the
minimal-reqs
branch
from
ba9e0dd to
2fe4e02
Compare
|
Any other thoughts on this? @mroeschke @lithomas1 @fangchenli |
.github/workflows/python-dev.yml
Outdated
| python -m pip install git+https://github.com/nedbat/coveragepy.git | ||
| python -m pip install versioneer[toml] | ||
| python -m pip install python-dateutil pytz cython hypothesis==6.52.1 pytest>=6.2.5 pytest-xdist pytest-cov pytest-asyncio>=0.17 | ||
| python -m pip install -r ci/deps/requirements-minimal.txt pytest-cov pytest-xdist |
There was a problem hiding this comment.
On second thought, are you sure pytest-xdist is not required? I remember having to install it once for some test(it was using one of the pytest-xdist fixtures).
There was a problem hiding this comment.
Yeah the S3 tests use the worker_id pytest-xdist fixture. All of them should be marked with single_cpu so I guess in this job those should be skipped. Might make sense to include pytest-xdist just in case anything changes
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
We've got 2 approvals on this. Rather then let it go stale let's merge in on next conflict fixup, unless someone objects |
This reverts commit b6f277c.
|
this workflow isn't actually running at the moment, so marking as draft until it's re-enabled #50696 (comment) |
|
closing to clear the queue, might pick it up again in the future |
4 participants
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.