TST: Verify isin returns consistent results for passed iterables #50443
Conversation
…lts for passed iterables
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
This is off to a good start!
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
couple more minor comments, then looks good to me
@phofl any further comments?
|
|
||
| @pytest.mark.parametrize( | ||
| "data", | ||
| [([1, 2, 3]), ([1.0, 2.0, 3.0])], |
There was a problem hiding this comment.
looks like you've got some extra brackets (I'm surprised none of the linters caught this)
| [([1, 2, 3]), ([1.0, 2.0, 3.0])], | |
| [[1, 2, 3], [1.0, 2.0, 3.0]], |
| # GH 50234 | ||
|
|
||
| ser = Series(data) | ||
| result = ser.isin(i for i in [1, 2]) |
There was a problem hiding this comment.
sorry, I didn't catch this the first time round - doesn't the original issue have (i for i in [1.0, 2.0])?
There was a problem hiding this comment.
Agreed, we should parametrize over both, e.g. [1, 2] and [1.0, 2.0]
There was a problem hiding this comment.
Good point! Updated parameters accordingly.
There was a problem hiding this comment.
Nice, thanks @jessica-writes-code ! Looks good to me pending green
phofl
added
the
Algos
3 participants
Add tests to verify that the
Seriesmethodisinreturns consistent results when passed iterables with different dtypes. (See #50234.)Added type annotations to new arguments/methods/functions.(Not applicable.)Added an entry in the latest(Not applicable.)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.