TEST: added test case for issue 41800 #50677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 12, 2023
| freq="H", | ||
| tz="Europe/Rome" | ||
| ) | ||
| s1 = Series(np.random.random(10), index=time_index) |
Member
There was a problem hiding this comment.
Could you use range(10) instead and then using tm.assert_series.equals instead of tm.assert_equal?
mroeschke
reviewed
Jan 12, 2023
|
|
||
| def test_combine_first_timezone_series_with_empty_series(self): | ||
| # GH 41800 | ||
| time_index = pd.date_range( |
Member
There was a problem hiding this comment.
Suggested change
| time_index = pd.date_range( | |
| time_index = date_range( |
mroeschke
added
the
Testing
mroeschke
approved these changes
Jan 12, 2023
Member
|
Thanks @lpizzinidev |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Jan 12, 2023
* TEST: added test case for issue 41800 addresses pandas-dev#41800 * fix lint error * fix lint error * added assert_series_equal control and changed date_range call
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Jan 13, 2023
* TEST: added test case for issue 41800 addresses pandas-dev#41800 * fix lint error * fix lint error * added assert_series_equal control and changed date_range call
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.