PERF: Improve performance for array equal fast #50850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 19, 2023
pandas/_libs/lib.pyx
Outdated
| def array_equal_fast( | ||
| ndarray[int6432_t, ndim=1] left, ndarray[int6432_t, ndim=1] right, | ||
| ) -> bool: | ||
| def indexer_equal_fast(ndarray[int6432_t, ndim=1] left, int n) -> bool: |
Member
There was a problem hiding this comment.
While renaming this function, maybe is_range_indexer might be more appropriate? Or at least clarifying that this only compares if the indexer is equal to range(n)
Member
Author
There was a problem hiding this comment.
Yeah thought about this myself and agree.
jorisvandenbossche
approved these changes
Jan 20, 2023
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Yes, looks good! (that's what I had in mind as well)
pooja-subramaniam
pushed a commit
to pooja-subramaniam/pandas
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.gives us a 50% boost if everything is equal and reduces it to nanoseconds if the first non-equal element is within the first couple elements compared to 500 microseconds