REF: GroupBy.ops don't depend on mutation status #51102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Feb 1, 2023
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
+1 i think you removed the affected cases a long time ago
mroeschke
approved these changes
Feb 1, 2023
Member
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.mutatedis only used in one place (see one-line edit in first commit) and removing that doesn't break anything. Conceivably could change some behavior but until we have an example I don't think it is even worth documenting as an API change.Might be leftover from the old libreduction path?
cc @jreback for the deep cut into the history