Skip to content

CLN: Remove default for columns in pivot #51367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarcoGorelli merged 2 commits into from
Feb 14, 2023
Merged

CLN: Remove default for columns in pivot #51367

MarcoGorelli merged 2 commits into from
Feb 14, 2023

Conversation

@phofl
Copy link
Member

@phofl phofl commented Feb 13, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Feb 14, 2023
MarcoGorelli
MarcoGorelli approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phofl

@MarcoGorelli MarcoGorelli merged commit 107c64f into pandas-dev:main Feb 14, 2023
@MarcoGorelli MarcoGorelli mentioned this pull request Feb 14, 2023
Merged
5 tasks
@phofl phofl deleted the pivot branch February 14, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Clean

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@phofl @MarcoGorelli