Skip to content

BUG: Series.getitem not respecting CoW with MultiIndex #51950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phofl merged 2 commits into from
Mar 15, 2023
Merged

BUG: Series.getitem not respecting CoW with MultiIndex #51950

phofl merged 2 commits into from
Mar 15, 2023

Conversation

@phofl
Copy link
Member

@phofl phofl commented Mar 13, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added this to the 2.0 milestone Mar 13, 2023
@phofl phofl mentioned this pull request Mar 15, 2023
Merged
5 tasks
jorisvandenbossche
jorisvandenbossche approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Mar 15, 2023

Ah, this needs a merge of main now

@phofl
Merge remote-tracking branch 'upstream/main' into cow_series_midx_slice
b0a68c8 
# Conflicts:
#	doc/source/whatsnew/v2.0.0.rst
#	pandas/tests/copy_view/test_indexing.py
@phofl phofl mentioned this pull request Mar 15, 2023
Merged
5 tasks
@phofl phofl merged commit a083567 into pandas-dev:main Mar 15, 2023
@phofl phofl deleted the cow_series_midx_slice branch March 15, 2023 22:36
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 15, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 15, 2023
@phofl @meeseeksmachine
Backport PR pandas-dev#51950: BUG: Series.getitem not respecting CoW …
a0c82d8 
…with MultiIndex
phofl added a commit that referenced this pull request Mar 16, 2023
@meeseeksmachine @phofl
Backport PR #51950 on branch 2.0.x (BUG: Series.getitem not respectin…
6b6c336 
…g CoW with MultiIndex) (#52005)

Backport PR #51950: BUG: Series.getitem not respecting CoW with MultiIndex

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees

No one assigned

Labels

Copy / view semantics

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@phofl @jorisvandenbossche