Skip to content

CLN: Refactor validate_min_versions_in_sync.py #51981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroeschke merged 2 commits into from
Mar 17, 2023
Merged

CLN: Refactor validate_min_versions_in_sync.py #51981

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73a9c1e
Minor fix
kathleenhang Mar 15, 2023
1ea59d5
Merge branch 'main' into minor-fix
MarcoGorelli Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions scripts/validate_min_versions_in_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@
YAML_PATH = pathlib.Path("ci/deps")
ENV_PATH = pathlib.Path("environment.yml")
EXCLUDE_DEPS = {"tzdata", "blosc"}
EXCLUSION_LIST = {
"python=3.8[build=*_pypy]": None,
"pyarrow": None,
}
EXCLUSION_LIST = frozenset(["python=3.8[build=*_pypy]", "pyarrow"])
# pandas package is not available
# in pre-commit environment
sys.path.append("pandas/compat")
Expand Down Expand Up @@ -166,9 +163,7 @@ def pin_min_versions_to_yaml_file(
continue
old_dep = yaml_package
if yaml_versions is not None:
for yaml_version in yaml_versions:
old_dep += yaml_version + ", "
old_dep = old_dep[:-2]
old_dep = old_dep + ", ".join(yaml_versions)
if RENAME.get(yaml_package, yaml_package) in toml_map:
min_dep = toml_map[RENAME.get(yaml_package, yaml_package)]
elif yaml_package in toml_map:
Expand Down