Skip to content

FIX: OLS.predict() - cast input to DataFrame from Series before performing operations #5234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rockg wants to merge 2 commits into from
Closed

FIX: OLS.predict() - cast input to DataFrame from Series before performing operations #5234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4edc28c
Cast input to DataFrame from Series before performing operations
rockg Oct 15, 2013
f8ee140
Fix bug OLS.predict() when Series is passed by casting to DataFrame f…
rockg Oct 15, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/stats/ols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,12 +445,12 @@ def predict(self, beta=None, x=None, fill_value=None,
orig_x = x
else:
orig_x = x
if isinstance(x, Series):
x = DataFrame({'x': x})
if fill_value is None and fill_method is None:
x = x.dropna(how='any')
else:
x = x.fillna(value=fill_value, method=fill_method, axis=axis)
if isinstance(x, Series):
x = DataFrame({'x': x})
if self._intercept:
x['intercept'] = 1.

Expand Down
3 changes: 3 additions & 0 deletions pandas/stats/tests/test_ols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,9 @@ def test_series_rhs(self):
model = ols(y=y, x=x)
expected = ols(y=y, x={'x': x})
assert_series_equal(model.beta, expected.beta)

# Test predict using a series
assert_series_equal(model.y_predict, model.predict(x=x))

def test_various_attributes(self):
# just make sure everything "works". test correctness elsewhere
Expand Down