Added tests for period str and repr. #53003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 29, 2023 16:17
Contributor
Author
|
All set - Ready for review @MarcoGorelli ! |
mroeschke
added
Testing
MarcoGorelli
approved these changes
May 5, 2023
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
thanks @smarie , nice one!
MarcoGorelli
added
Needs Tests
Contributor
Author
|
Thanks @MarcoGorelli for the quick review ! We can now proceed with #51459 , I updated the PR. |
3 tasks
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
* Added tests for period str and repr. Fixes pandas-dev#53000 * Removed commented params in test, improved test for repr, and blackened. * Better tests * Moved the two independent tests into parametrized test --------- Co-authored-by: Sylvain MARIE <sylvain.marie@se.com>
5 tasks
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* Added tests for period str and repr. Fixes pandas-dev#53000 * Removed commented params in test, improved test for repr, and blackened. * Better tests * Moved the two independent tests into parametrized test --------- Co-authored-by: Sylvain MARIE <sylvain.marie@se.com>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* Added tests for period str and repr. Fixes pandas-dev#53000 * Removed commented params in test, improved test for repr, and blackened. * Better tests * Moved the two independent tests into parametrized test --------- Co-authored-by: Sylvain MARIE <sylvain.marie@se.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repr(pd.Period)#53000