BUG: groupby sum turning inf+inf and (-inf)+(-inf) into nan
#53623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Jun 13, 2023
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
Looks good! A few minor requests.
Member
|
@Charlie-XIAO - small note, we like to use for more details. |
Contributor
Author
Oh sure, sorry about that. I mixed up with the prefix of another project lol. |
Charlie-XIAO
changed the title
Charlie-XIAO
changed the title
Charlie-XIAO
changed the title
np.inf+np.inf and (-np.inf)+(-np.inf) into nan
Charlie-XIAO
changed the title
np.inf+np.inf and (-np.inf)+(-np.inf) into naninf+inf and (-inf)+(-inf) into nan
Member
|
Thanks @Charlie-XIAO! |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Jun 15, 2023
mroeschke
added a commit
that referenced
this pull request
Jun 21, 2023
* CI: Build pandas even if doctests fail * BUG: groupby sum turning `inf+inf` and `(-inf)+(-inf)` into `nan` (#53623) * DEPR: method, limit in NDFrame.replace (#53492) * DEPR: method, limit in NDFrame.replace * update test, docs * suppress doctest warning * doctests * PERF: Series.str.get_dummies for ArrowDtype(pa.string()) (#53655) * PERF: Series.str.get_dummies for ArrowDtype(pa.string()) * whatsnew * typing * TYP: core.missing (#53625) * CI: Attempt to fix wheel builds (#53670) * DOC: Fixing EX01 - Added examples (#53647) * SeriesGroupBy.fillna example added * Added examples * Corrected failing test for timedelta.total_seconds * Corrected fillna example * CI/TST: Mark test_to_read_gcs as single_cpu (#53677) * BUG/CoW: is_range_indexer can't handle very large arrays (#53672) * BUG: is_range_indexer can't handle very large arrays * fix test on 32-bit * TST: Use more pytest fixtures --------- Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com> Co-authored-by: jbrockmendel <jbrockmendel@gmail.com> Co-authored-by: Luke Manley <lukemanley@gmail.com> Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com> Co-authored-by: Dea María Léon <deamarialeon@gmail.com>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* CI: Build pandas even if doctests fail * BUG: groupby sum turning `inf+inf` and `(-inf)+(-inf)` into `nan` (pandas-dev#53623) * DEPR: method, limit in NDFrame.replace (pandas-dev#53492) * DEPR: method, limit in NDFrame.replace * update test, docs * suppress doctest warning * doctests * PERF: Series.str.get_dummies for ArrowDtype(pa.string()) (pandas-dev#53655) * PERF: Series.str.get_dummies for ArrowDtype(pa.string()) * whatsnew * typing * TYP: core.missing (pandas-dev#53625) * CI: Attempt to fix wheel builds (pandas-dev#53670) * DOC: Fixing EX01 - Added examples (pandas-dev#53647) * SeriesGroupBy.fillna example added * Added examples * Corrected failing test for timedelta.total_seconds * Corrected fillna example * CI/TST: Mark test_to_read_gcs as single_cpu (pandas-dev#53677) * BUG/CoW: is_range_indexer can't handle very large arrays (pandas-dev#53672) * BUG: is_range_indexer can't handle very large arrays * fix test on 32-bit * TST: Use more pytest fixtures --------- Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com> Co-authored-by: jbrockmendel <jbrockmendel@gmail.com> Co-authored-by: Luke Manley <lukemanley@gmail.com> Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com> Co-authored-by: Dea María Léon <deamarialeon@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy.Infbetweengroupby.sum()andgroupby.apply(lambda: _grp: _grp.sum())#53606doc/source/whatsnew/v2.1.0.rstfileThis modifies
group_sumin almost the way as #52964 forgroup_mean.