Skip to content

Conversation

@vvaidy
Copy link
Contributor

@vvaidy vvaidy commented Jul 15, 2023

@noatamir @phofl SciPy 2023 sprint

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

Examples
--------
>>> import pandas as pd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed (it fails a check).

foo bar
0 3 8
1 4 9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blank line here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and pushed. Tested locally with ci/code_checks.sh docstrings and seems to check clean

@mroeschke
Copy link
Member

Can you remove pandas.read_parquet \ from code_checks.sh?

…d read_parquet from code_checks.sh as requested by @mroeschke
@vvaidy vvaidy requested a review from mroeschke as a code owner July 18, 2023 19:02
@vvaidy
Copy link
Contributor Author

vvaidy commented Jul 18, 2023

Hi @mroeschke,

No problem. I did as you requested and reran the tests locally and they succeeded.

I must confess I don't quite understand the implications of that change, but I will look it over later tonight. In the meanwhile, it's done, tested locally and pushed.

Do LMK if you need anything else. Thx.

@mroeschke mroeschke added Docs IO Parquet parquet, feather labels Jul 18, 2023
@mroeschke mroeschke added this to the 2.1 milestone Jul 18, 2023
@mroeschke mroeschke merged commit 064781c into pandas-dev:main Jul 18, 2023
@mroeschke
Copy link
Member

Thanks @vvaidy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs IO Parquet parquet, feather

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants