Remove test_groupby_agg_extension (marked xfail) #54272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove special `test_groupby_agg_extension` in `test_json.py` as we can now pass the test generally with these fixes to `GroupBy.first` and `GroupBy.last`. Signed-off-by: Michael Tiemann <72577720+MichaelTiemannOSC@users.noreply.github.com>
Fix sort order. Signed-off-by: Michael Tiemann <72577720+MichaelTiemannOSC@users.noreply.github.com>
Contributor
Author
|
In the course of winnowing away unnecessary changes in a PR related to extension arrays, I found that this was one useful result of that work. I'm re-submitting as a fresh PR that specifically fixes a single reported bug, following guidance in that bug report, and what I've learned along the way. |
mroeschke
reviewed
Jul 27, 2023
mroeschke
reviewed
Jul 27, 2023
Incorporate suggestions from @mroeschke (consolidating docs and fixing a malformed return statement). Signed-off-by: Michael Tiemann <72577720+MichaelTiemannOSC@users.noreply.github.com> Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
mroeschke
approved these changes
Jul 28, 2023
Member
|
Thanks @MichaelTiemannOSC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove special
test_groupby_agg_extensionintest_json.pyas we can now pass the test generally with these fixes toGroupBy.firstandGroupBy.last.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.