Skip to content

CLN: VariableOffsetWindowIndexer #54379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 3 commits into from
Aug 4, 2023
Merged

CLN: VariableOffsetWindowIndexer #54379

mroeschke merged 3 commits into from
Aug 4, 2023

Conversation

@mroeschke
Copy link
Member

@mroeschke mroeschke commented Aug 3, 2023

  • Improved typing
  • Added validation to arguments
  • Clarified steps in get_window_bounds

@mroeschke mroeschke added Clean Window rolling, ewma, expanding labels Aug 3, 2023
@mroeschke mroeschke added this to the 2.1 milestone Aug 3, 2023
@mroeschke
Copy link
Member Author

mroeschke commented Aug 4, 2023

Looks like checks are passing here so merging. Can follow up if needed

@mroeschke mroeschke merged commit 0eeb8cb into pandas-dev:main Aug 4, 2023
@mroeschke mroeschke deleted the enh/variableindexer branch August 4, 2023 17:06
@cmp0xff cmp0xff mentioned this pull request Dec 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Clean Window rolling, ewma, expanding

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

1 participant

@mroeschke