TST: add test for mixed dtypes of df col index #47382 #55720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 27, 2023
| df2 = DataFrame(columns=list("abc"), data=0.0, index=[0]) | ||
| df1.columns = df2.columns.astype("string") | ||
| df3 = df1 + df2 | ||
| assert df3.columns.dtype == "object" |
Member
There was a problem hiding this comment.
Could you construct an expected DataFrame result and use tm.assert_frame_equal(result, expected)?
Contributor
Author
There was a problem hiding this comment.
Of course! Just committed that modification.
mroeschke
added
the
Testing
mroeschke
approved these changes
Oct 30, 2023
Member
|
Thanks @mliu08 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the code snippet reproducing the error into a test under tests/frame/test_arithmetic.py.