Skip to content

TST: use single-class pattern in test_string.py #56509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 7 commits into from
Dec 18, 2023
Merged

TST: use single-class pattern in test_string.py #56509

mroeschke merged 7 commits into from
Dec 18, 2023

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Dec 14, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel jbrockmendel mentioned this pull request Dec 15, 2023
Merged
@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Dec 15, 2023
@mroeschke mroeschke added this to the 2.2 milestone Dec 18, 2023
@mroeschke mroeschke merged commit 78d8b2e into pandas-dev:main Dec 18, 2023
@mroeschke
Copy link
Member

mroeschke commented Dec 18, 2023

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the tst-one-class-4 branch December 18, 2023 21:00
cbpygit pushed a commit to cbpygit/pandas that referenced this pull request Jan 2, 2024
@jbrockmendel @cbpygit
TST: use single-class pattern in test_string.py (pandas-dev#56509)
2e508e3 
* TST: use single-class pattern in test_string.py

* mypy fixup

* update pyarrow test

* __future__ import

* mypy fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @mroeschke @gfyoung