Skip to content

API: Expose api.typing.FrozenList for typing #58237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhshadrach merged 2 commits into from
Apr 15, 2024
Merged

API: Expose api.typing.FrozenList for typing #58237

rhshadrach merged 2 commits into from
Apr 15, 2024

Conversation

@mroeschke
Copy link
Member

@mroeschke mroeschke commented Apr 12, 2024

Since it was decided not to remove this in favor of tuple #57788, exposing FrozenList in .api.typing instead

@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Apr 12, 2024
@mroeschke mroeschke added this to the 3.0 milestone Apr 12, 2024
@mroeschke mroeschke requested a review from rhshadrach April 15, 2024 17:39
rhshadrach
rhshadrach approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit f30ebb6 into pandas-dev:main Apr 15, 2024
@rhshadrach
Copy link
Member

rhshadrach commented Apr 15, 2024

Thanks @mroeschke

@mroeschke mroeschke deleted the api/frozenlist branch April 15, 2024 20:42
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@mroeschke @pmhatre1
API: Expose api.typing.FrozenList for typing (pandas-dev#58237)
e5cc261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees

No one assigned

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mroeschke @rhshadrach