Skip to content

Fix merge error logging order #58310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroeschke merged 1 commit into from
Apr 18, 2024
Merged

Fix merge error logging order #58310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/core/reshape/merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2065,8 +2065,8 @@ def _validate_left_right_on(self, left_on, right_on):
or is_string_dtype(ro_dtype)
):
raise MergeError(
f"Incompatible merge dtype, {ro_dtype!r} and "
f"{lo_dtype!r}, both sides must have numeric dtype"
f"Incompatible merge dtype, {lo_dtype!r} and "
f"{ro_dtype!r}, both sides must have numeric dtype"
)

# add 'by' to our key-list so we can have it in the
Expand Down