Skip to content

TST: Fix CI failures (don't xfail postgresql / don't xfail for pyarrow=16) #58693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroeschke merged 6 commits into from
May 13, 2024
Merged

TST: Fix CI failures (don't xfail postgresql / don't xfail for pyarrow=16) #58693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84af226
TST: Fix test failures for test_api_read_sql_duplicate_columns and te…
Aloqeely May 13, 2024
4753b2f
Fix line length
Aloqeely May 13, 2024
45a968b
xfail if pyarrow version < 16
Aloqeely May 13, 2024
9c59eab
check name
Aloqeely May 13, 2024
2237793
Remove `strict` argument
Aloqeely May 13, 2024
dce25f1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pandas/tests/io/parser/test_multi_thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import pandas as pd
from pandas import DataFrame
import pandas._testing as tm
from pandas.util.version import Version

xfail_pyarrow = pytest.mark.usefixtures("pyarrow_xfail")

Expand All @@ -24,10 +25,16 @@
]


@xfail_pyarrow # ValueError: Found non-unique column index
def test_multi_thread_string_io_read_csv(all_parsers):
@pytest.mark.filterwarnings("ignore:Passing a BlockManager:DeprecationWarning")
def test_multi_thread_string_io_read_csv(all_parsers, request):
# see gh-11786
parser = all_parsers
if parser.engine == "pyarrow":
pa = pytest.importorskip("pyarrow")
if Version(pa.__version__) < Version("16.0"):
request.applymarker(
pytest.mark.xfail(reason="# ValueError: Found non-unique column index")
)
max_row_range = 100
num_files = 10

Expand Down
3 changes: 2 additions & 1 deletion pandas/tests/io/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2302,7 +2302,8 @@ def test_api_read_sql_duplicate_columns(conn, request):
if "adbc" in conn:
pa = pytest.importorskip("pyarrow")
if not (
Version(pa.__version__) >= Version("16.0") and conn == "sqlite_adbc_conn"
Version(pa.__version__) >= Version("16.0")
and conn in ["sqlite_adbc_conn", "postgresql_adbc_conn"]
):
request.node.add_marker(
pytest.mark.xfail(
Expand Down